Add sort by Wi-Fi Standard option to AccessPoints view by gioalex07 · Pull Request #604 · VREMSoftwareDevelopment/WiFiAnalyzer

gioalex07 · 2026-04-02T23:50:20Z

Summary

Add STANDARD as a new sort option in the Access Points view.
Users can now sort access points by Wi-Fi standard descending (Wi-Fi 7 → Wi-Fi 6 → Wi-Fi 5 → Wi-Fi 4 → Legacy → Unknown).

What does this implement/fix?

The WiFiStandard enum and its detection logic (WiFiStandard.findOne()) were already fully
implemented but not exposed as a sort criteria. This change adds STANDARD to SortBy following
the exact same pattern as the existing STRENGTH, SSID and CHANNEL options.

Sort order for STANDARD:

Primary: Wi-Fi standard descending by wiFiStandardId (BE=8 > AX=6 > AD=7 > AC=5 > N=4 > LEGACY=1 > UNKNOWN=0)
Secondary: signal strength descending
Tertiary: SSID ascending
Quaternary: BSSID ascending

Files changed:

wifi/model/SortBy.kt — add sortByStandard() comparator and STANDARD enum entry
res/values/arrays.xml — add index and label to sort_by_index_array and sort_by_array
res/values/strings.xml — add sort_by_standard string resource
wifi/model/SortByTest.kt — update size assertion, add ordinal and comparator assertions

Does this close any issues?

N/A (new feature)

How was this tested?

Platform: WSL2 / AlmaLinux 9
Build variant: debug
Toolchain: JDK 21 (Zulu), Gradle 9.3.1, Android SDK 36, Kotlin 2.3.0

./gradlew ktlintFormat                                             → BUILD SUCCESSFUL
./gradlew ktlintCheck                                              → BUILD SUCCESSFUL
./gradlew testDebugUnitTest                                        → BUILD SUCCESSFUL (3432 tests)

Checklist (required before marking ready)

I added or updated unit tests (see app/src/test/)
I followed the project's coding style (ktlint) and formatting
I ran lint and addressed or documented any warnings
CI checks pass (unit tests, coverage, lint)
No sensitive data, keys, or secrets are included

Additional context

On devices running Android 10 or earlier (< Build.VERSION_CODES.R), WiFiStandard returns
UNKNOWN for all access points — this is existing behavior handled by WiFiStandard.findOne().
The sort remains stable in that case since tiebreakers (strength, SSID, BSSID) still apply.

Note: translations for sort_by_standard in non-English locales are not included in this PR
as the string is currently marked translatable="false" consistent with sort_by_ssid in the
existing codebase.

Add STANDARD as a new SortBy option that orders access points by Wi-Fi standard descending (BE > AX > AC > N > LEGACY > UNKNOWN), with signal strength, SSID and BSSID as tiebreakers. - SortBy.kt: add sortByStandard() comparator and STANDARD enum entry - arrays.xml: add Standard option to sort_by_index_array and sort_by_array - strings.xml: add sort_by_standard string resource - SortByTest.kt: update size, ordinal and comparator assertions

VREMSoftwareDevelopment · 2026-04-04T14:19:39Z

Thanks for the contribution.

AI Usage Disclosure
Disclose any AI tool involvement and use the “AI assistance used” label.
Testing Requirements
Changes must be tested on a real Android device.
Emulator‑only testing or running build tasks (e.g., ktlintCheck, unit tests, successful Gradle build) is not sufficient.
UI/UX behavior, layouts, gestures, and rendering often differ between emulators and actual devices.

Please update the PR with real‑device testing details so review can continue.

codecov · 2026-04-04T14:25:48Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.83%. Comparing base (e3b385e) to head (8c6f3c5).

Additional details and impacted files

@@            Coverage Diff            @@
##               main     #604   +/-   ##
=========================================
  Coverage     97.83%   97.83%           
  Complexity      975      975           
=========================================
  Files           121      121           
  Lines          2581     2586    +5     
  Branches        211      211           
=========================================
+ Hits           2525     2530    +5     
  Misses           19       19           
  Partials         37       37

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copilot

Pull request overview

Adds a new Access Points sorting option to expose the existing WiFiStandard detection logic as a user-selectable sort criterion.

Changes:

Add STANDARD to SortBy with a dedicated comparator (sortByStandard()).
Expose the new sort option in Settings resources (arrays.xml, strings.xml).
Update unit tests to cover the new enum entry and comparator wiring.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.

File	Description
app/src/main/kotlin/com/vrem/wifianalyzer/wifi/model/SortBy.kt	Adds `sortByStandard()` comparator and `SortBy.STANDARD` entry.
app/src/main/res/values/arrays.xml	Adds index/label entries so Settings can display and persist the new sort option.
app/src/main/res/values/strings.xml	Adds the `sort_by_standard` label string.
app/src/test/kotlin/com/vrem/wifianalyzer/wifi/model/SortByTest.kt	Updates assertions for the new `SortBy` entry.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-04-25T22:48:39Z

    <string name="security_wps" translatable="false">"WPS"</string>
    <string name="selected_menu_key" translatable="false">"selected_menu"</string>
    <string name="sort_by_channel">"Channel"</string>
+    <string name="sort_by_standard" translatable="false">"Standard"</string>


sort_by_standard is marked translatable="false", but the other user-visible sort labels nearby (e.g., sort_by_channel, sort_by_signal_strength) are translatable. If this label should be localized like the others, remove translatable="false" (or otherwise align the translation policy across the sort-by labels).

Suggested change

<string name="sort_by_standard" translatable="false">"Standard"</string>

<string name="sort_by_standard">"Standard"</string>

Copilot · 2026-04-25T22:48:40Z

+fun sortByStandard(): Comparator<WiFiDetail> =
+    compareByDescending<WiFiDetail> { it.wiFiSignal.extra.wiFiStandard.wiFiStandardId }
+        .thenByDescending { it.wiFiSignal.level }


sortByStandard() currently sorts by wiFiStandardId descending, which will place 802.11ad (id=7) ahead of 802.11ax (id=6). This doesn’t match the PR description’s stated Wi‑Fi generation order (7 → 6 → 5 → 4 → Legacy → Unknown). Consider defining an explicit ranking (e.g., mapping WiFiStandard to a sort key) so the sort order matches the intended UX, and treat 11ad/WiGig explicitly (either between 7 and 6 by design, or below 6).

Copilot · 2026-04-25T22:48:40Z

    <string-array name="sort_by_index_array" translatable="false">
        <item>0</item>
        <item>1</item>
-        <item>2</item>
+	<item>2</item>
+	<item>3</item>
    </string-array>


These newly added <item> lines are indented with tab characters, while the surrounding XML uses spaces. Please replace tabs with spaces to keep formatting consistent and avoid whitespace-only diffs/noise in future changes.

Copilot · 2026-04-25T22:48:40Z

    <string-array name="sort_by_array">
        <item>@string/sort_by_signal_strength</item>
        <item>@string/sort_by_ssid</item>
-        <item>@string/sort_by_channel</item>
+	<item>@string/sort_by_channel</item>
+	<item>@string/sort_by_standard</item>
    </string-array>


The new entries in sort_by_array are indented with tabs, unlike the rest of this file which uses spaces. Please normalize indentation (spaces) for consistency.

Ghost

gioalex07 and others added 2 commits April 2, 2026 18:49

Merge branch 'main' into feature/sort-by-standard

dd1c0a5

Merge branch 'main' into feature/sort-by-standard

f184ee0

VREMSoftwareDevelopment added the AI assistance used Indicates that an AI assistant was used to generate this PR label Apr 4, 2026

VREMSoftwareDevelopment added 2 commits April 22, 2026 11:32

Merge branch 'main' into feature/sort-by-standard

0008fcd

Merge branch 'main' into feature/sort-by-standard

8c6f3c5

VREMSoftwareDevelopment requested a review from Copilot April 25, 2026 22:45

Copilot started reviewing on behalf of VREMSoftwareDevelopment April 25, 2026 22:46 View session

Copilot AI reviewed Apr 25, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add sort by Wi-Fi Standard option to AccessPoints view#604

Add sort by Wi-Fi Standard option to AccessPoints view#604
gioalex07 wants to merge 5 commits intoVREMSoftwareDevelopment:mainfrom
gioalex07:feature/sort-by-standard

gioalex07 commented Apr 2, 2026

Uh oh!

VREMSoftwareDevelopment commented Apr 4, 2026

Uh oh!

codecov Bot commented Apr 4, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Apr 25, 2026

Uh oh!

Copilot AI Apr 25, 2026

Uh oh!

Copilot AI Apr 25, 2026

Uh oh!

Copilot AI Apr 25, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

	<string name="sort_by_standard" translatable="false">"Standard"</string>
	<string name="sort_by_standard">"Standard"</string>

Conversation

gioalex07 commented Apr 2, 2026

Summary

What does this implement/fix?

Does this close any issues?

How was this tested?

Checklist (required before marking ready)

Additional context

Uh oh!

VREMSoftwareDevelopment commented Apr 4, 2026

Uh oh!

codecov Bot commented Apr 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Apr 25, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 25, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 25, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 25, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

codecov Bot commented Apr 4, 2026 •

edited

Loading